19204 Fixed whitespace between sub-title and body

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 52 forks source link

19204 Fixed whitespace between sub-title and body #612

Closed severinbeauvais closed 9 months ago

severinbeauvais commented 9 months ago

Issue #: bcgov/entity#19204

Description of changes:

app version = 7.0.37
removed min-height (which simulated padding when it's a single line)
added top margin (whitespace whether it's a single or wrapped line)
added top padding to body for all filings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

sonarcloud[bot] commented 9 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

severinbeauvais commented 9 months ago

Sample whitespace for an IA (temp view):

Sample whitespace for an IA (business view):

Sample whitespace for an alteration:

severinbeauvais commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-filings-dev--pr-612-krqcgxqz.web.app