19781 Updated draft amalgamation task/filing display name

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

19781 Updated draft amalgamation task/filing display name #620

Closed severinbeauvais closed 7 months ago

severinbeauvais commented 7 months ago

Issue #: bcgov/entity#19781

Description of changes:

app version = 7.0.42
refactored aboutText into aboutApp and aboutSbc
added special cases for displaying draft amalgamation task/filing name
now display aboutApp in console
updated filingTypeToName()
updated unit tests
deleted local font preload

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ketaki-deodhar commented 7 months ago

Ticket is for Legal-api. This fix is only to change the draft name? Still needs any fix in Legal-api?

severinbeauvais commented 7 months ago

Ticket is for Legal-api. This fix is only to change the draft name? Still needs any fix in Legal-api?

Yes, Legal API still needs a change to provide the updated ledger entry displayName.

severinbeauvais commented 7 months ago

/gcbrun

bcregistry-sre commented 7 months ago

Temporary Url for review: https://business-filings-dev--pr-620-0yidv0bb.web.app