bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

19396 Fixed consent for continuation out expiry bug #633

Closed severinbeauvais closed 6 months ago

severinbeauvais commented 6 months ago

Issue #: bcgov/entity#19396

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (1ac27d5) to head (f29a719). Report is 95 commits behind head on main.

:exclamation: Current head f29a719 differs from pull request most recent head e5ba99e. Consider uploading reports for the commit e5ba99e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #633 +/- ## ========================================= - Coverage 92.44% 0 -92.45% ========================================= Files 171 0 -171 Lines 2793 0 -2793 Branches 309 0 -309 ========================================= - Hits 2582 0 -2582 + Misses 210 0 -210 + Partials 1 0 -1 ``` [see 165 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/business-filings-ui/pull/633/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

severinbeauvais commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-filings-dev--pr-633-cnmp98jh.web.app

SB says, I don't have any subject filings in Filed and Pending status but you can try these:

Sample "filed and pending" (tested by hacking data locally):

image