16847 Removed ledger detail in consent continue out / consent amalgamation out filings

severinbeauvais commented 7 months ago

Issue #: bcgov/entity#16847

Description of changes:

app version = ~7.1.4~ 7.1.6
removed ledger detail ~for non-staff user~ for all users
updated validation logic
updated saveFiling()
updated unit tests

Also:

removed windows event handler when local filings views are destroyed

Also:

fixed some filing body margins
fixed ApiFilingIF.continuationOut object

Also:

fixed some calls that didn't need parameters
fixed some typings
removed order details display from CCO ledger item
removed ledger detail section from CCO and CAO sub-components + all supporting code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 7 months ago

/gcbrun

sonarcloud[bot] commented 7 months ago

Quality Gate failed

Failed conditions
18.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

bcregistry-sre commented 7 months ago

Temporary Url for review: https://business-filings-dev--pr-637-xpplthpp.web.app

SB says, try this: https://business-filings-dev--pr-637-xpplthpp.web.app/BC0873420/

bcgov / business-filings-ui

16847 Removed ledger detail in consent continue out / consent amalgamation out filings #637

Quality Gate failed