bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

Implemented easy legal name fix + unit tests #648

Closed JazzarKarim closed 5 months ago

JazzarKarim commented 5 months ago

Issue #: /bcgov/entity#20779

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-filings-dev--pr-648-7xrf7iic.web.app

Please try: https://business-filings-dev--pr-648-7xrf7iic.web.app/BC0873409 (BEN) https://business-filings-dev--pr-648-7xrf7iic.web.app/FM1072274 (SP)

Keep in mind, in DEV, the FF is enabled. Because the backend hasn't been done to return the AlternateNames array in the business reponse yet, the UI will show Unknown for firms.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

JazzarKarim commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-filings-dev--pr-648-7xrf7iic.web.app