bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

20534-remove-details-field-for-users #651

Closed jamespaologarcia closed 6 months ago

jamespaologarcia commented 6 months ago

Issue #: /bcgov/entity#20534

Updated the details field for continue out so it's required for Staff filings but not for regular users.

Set the default value to null

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

jamespaologarcia commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-filings-dev--pr-651-qfwvozrp.web.app

severinbeauvais commented 6 months ago

As a general rule, you should run npm run lint and npm run test:unit locally before you ask for a PR to be reviewed.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jamespaologarcia commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-filings-dev--pr-651-qfwvozrp.web.app

ketaki-deodhar commented 6 months ago

As a general rule, you should run npm run lint and npm run test:unit locally before you ask for a PR to be reviewed.

I second that :)