search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

21439 - Fixed unknown name when firm is filed and pending #663

Closed JazzarKarim closed 5 months ago

JazzarKarim commented 5 months ago

Issue #: /bcgov/entity#21439

Description of changes: In my last PR, i missed the case when the firm is filed but still not completed. Basically what I had before isDraftRegistration was not enough.

When the SP or GP is filed and pending, it's not draft anymore but at the same time it's not completed. So, the alternate names array is not found.

Before: before unknown

After: after sp unknown

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 5 months ago

/gcbrun

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-filings-dev--pr-663-5280atgu.web.app