bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

21194 Added handling for pending filing with completed payment #665

Closed severinbeauvais closed 5 months ago

severinbeauvais commented 5 months ago

Issue #: bcgov/entity#21194

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).


before

image.png

after

image.png
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

severinbeauvais commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-filings-dev--pr-665-dovqwyal.web.app

SB says, try this one: https://business-filings-dev--pr-665-dovqwyal.web.app/TItNIA7UFN?filing_id=149217&accountid=3040

Or, if the one above magically completes, try filing something else. You have a 50% change of it getting stuck in this state 😆

severinbeauvais commented 5 months ago

Looks good. Just a small observation (hope it's not just me that see this :D). Word "Paid" looks like "Pald". Probably not much we can do.

I see it, too. It's a font issue. Here it is a bit larger:

image

This has been happening for several years. Yui never pursued it 🤷‍♂️

ketaki-deodhar commented 5 months ago

Looks good. Just a small observation (hope it's not just me that see this :D). Word "Paid" looks like "Pald". Probably not much we can do.

I see it, too. It's a font issue. Here it is a bit larger:

image

This has been happening for several years. Yui never pursued it 🤷‍♂️

Yes. Looks okay in larger font.