20808 Added corp types + misc cleanup

severinbeauvais commented 3 months ago

Issue #: bcgov/entity#20808

Description of changes:

app version = 7.2.15
renamed isBenBcCccUlc -> isBaseCompany (same as Create UI)
fixed incorrect isSame() "id" parameter
renamed isCorp -> isCorporation
added disableCorrection condition
updated isBaseCompany to look at C/CBEN/CCC/CUL
fixed small Future-Effective and Future-Effective-Pending bugs
moved disableCorrection() tests out of Filing History List test suite
created Header Actions test suite for disableCorrection tests()
fixed and updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 3 months ago

/gcbrun

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-filings-dev--pr-666-p0fdewct.web.app

bcgov / business-filings-ui

20808 Added corp types + misc cleanup #666

Quality Gate passed