21897 - Fixed Upload Coverage to Codecov

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

21897 - Fixed Upload Coverage to Codecov #673

Closed JazzarKarim closed 3 months ago

JazzarKarim commented 3 months ago

Issue #: /bcgov/entity#21897

Description of changes:

No more failing on the testing-coverage step anymore!!!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 3 months ago

/gcbrun

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-filings-dev--pr-673-tsq3ckv3.web.app

JazzarKarim commented 3 months ago

Awesome!

Are you making this fix to Create UI and Edit UI?

Will someone else fix Namerequest UI and Auth Web?

Yup, I'm doing it also for Create UI and Edit UI. I'm doing them all as part of one ticket (https://github.com/bcgov/entity/issues/21897)

As for NR UI and Auth Web, I'm not too sure. I can probably fix them as well actually as part of my ticket or maybe let the two teams know. I'll take care of that!