bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

22248 - Disable codecov failure #678

Closed JazzarKarim closed 4 months ago

JazzarKarim commented 4 months ago

Issue #: /bcgov/entity#22248

Description of changes:

Following in the footsteps of Travis here: https://github.com/bcgov/sbc-auth/pull/2806

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 4 months ago

Looks fine.

I think you don't have to increment the app version if you do Create and Edit UIs, since the deployed image isn't changing, but no harm in it either.

Makes sense. I'm thinking we also don't need to for the release. When deploying, we're technically not deploying anything with this commit. I'll revert it here and for the other 2 repos, not going to update it.