21948 - Change Continuation Application

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 52 forks source link

21948 - Change Continuation Application #679

Closed ArwenQin closed 4 months ago

ArwenQin commented 4 months ago

Issue #: /bcgov/entity#21948

Description of changes:

Changed "Continuation In" to "Continuation Application"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

ArwenQin commented 4 months ago

Filing UI after change:

bcregistry-sre commented 4 months ago

Temporary Url for review: https://business-filings-dev--pr-679-2vtz07q6.web.app

severinbeauvais commented 4 months ago

Arwen, please revert the change in NameRequestInfo.vue (per Andy), and then attach some screenshots of what the Future Effective and Future Effective Pending filings look like. Did you confirm that the default values are not being used? Thanks.

ArwenQin commented 4 months ago

/gcbrun

ArwenQin commented 4 months ago

Arwen, please revert the change in NameRequestInfo.vue (per Andy), and then attach some screenshots of what the Future Effective and Future Effective Pending filings look like. Did you confirm that the default values are not being used? Thanks.

Hi Severin, I just updated the UIs per design of Andy, please see below.

ArwenQin commented 4 months ago

Future Effective Pending:

Andy's response: Use the word "Incorporation" for Continuation Application (same as IA)

ArwenQin commented 4 months ago

Future Effective Pending after change:

Per Figma: https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=2581-9069&t=OsBmB3ZE8NogZUwq-0