21977 Refactored Entity Status to support more bootstrap filing states cleanly

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

21977 Refactored Entity Status to support more bootstrap filing states cleanly #682

Closed severinbeauvais closed 2 months ago

severinbeauvais commented 2 months ago

Issue #: bcgov/entity#21977

This is another "small" PR to do some refactoring in preparation for future changes. This change should not affect current functionality.

Description of changes:

app version = 7.3.13
refactored Entity Status into Bootstrap Filing Status and Bootstrap Filing Type
refactored getters as above
deleted obsolete enum file entityStatus.ts
deleted obsolete store file state.ts
updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 2 months ago

/gcbrun

bcregistry-sre commented 2 months ago

Temporary Url for review: https://business-filings-dev--pr-682-gtb4b6a0.web.app

SB says, try these:

draft registration: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TdCmWDm84Y
draft ULC incorporation: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TbxCayouW2
completed BEN incorporation: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TlrCSZ7dgm
completed BC incorporation: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TSF9GeSBgM
completed CBEN continuation in: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TDt3xQkW0l
draft CUL continuation in: https://business-filings-dev--pr-682-gtb4b6a0.web.app/TqJpOqdQy5
awaiting review C continuation in: https://business-filings-dev--pr-682-gtb4b6a0.web.app//TmxEXv5iAW (*)

(*) the view for awaiting review continuation applications is still WIP