Closed ArwenQin closed 1 week ago
Test Note: Please Try:
I will update the unit tests later if the updates are ok.
/gcbrun
Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app
Updated the common Mixin and re-structured the codes. I will update the unit tests if these changes are ok.
/gcbrun
Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app
Looks good.
Remember to update the app version.
Also, please provide some Test Notes in the ticket to list what sorts of things QA should verify (and that you've also verified).
Sure, I will try to update some unit tests tmr. Thank you!
/gcbrun
@severinbeauvais I updated some unit tests. Is it good to merge now? Thanks!
Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app
Almost good to merge. There's an obsolete comment. After that, merge away :)
Failed conditions
15.4% Duplication on New Code (required ≤ 3%)
/gcbrun
Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app
Issue #: /bcgov/entity#21574
Description of changes: For all filings, including the "local filings" currently done in Filings UI (and which will stay in Filings UI). In this ticket, the following filings will "return" (actually, redirect) to the new Dashboard UI:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).