bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

21574 - Local Filing Return to Dashboard #692

Closed ArwenQin closed 1 week ago

ArwenQin commented 2 weeks ago

Issue #: /bcgov/entity#21574

Description of changes: For all filings, including the "local filings" currently done in Filings UI (and which will stay in Filings UI). In this ticket, the following filings will "return" (actually, redirect) to the new Dashboard UI:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

ArwenQin commented 2 weeks ago

Test Note: Please Try:

ArwenQin commented 2 weeks ago

I will update the unit tests later if the updates are ok.

ArwenQin commented 1 week ago

/gcbrun

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app

ArwenQin commented 1 week ago

Updated the common Mixin and re-structured the codes. I will update the unit tests if these changes are ok.

ArwenQin commented 1 week ago

/gcbrun

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app

ArwenQin commented 1 week ago

Looks good.

Remember to update the app version.

Also, please provide some Test Notes in the ticket to list what sorts of things QA should verify (and that you've also verified).

Sure, I will try to update some unit tests tmr. Thank you!

ArwenQin commented 1 week ago

/gcbrun

ArwenQin commented 1 week ago

@severinbeauvais I updated some unit tests. Is it good to merge now? Thanks!

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app

severinbeauvais commented 1 week ago

Almost good to merge. There's an obsolete comment. After that, merge away :)

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

ArwenQin commented 1 week ago

/gcbrun

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-filings-dev--pr-692-julisb6d.web.app