Backend change for SR Rules update

bcgov / business-schemas

Manages the JSONSchemas for the BCRegistry Legal Filings.

Apache License 2.0

4 stars 35 forks source link

Backend change for SR Rules update #129

Closed ritvick closed 1 year ago

ritvick commented 1 year ago

Issue #: /bcgov/entity/issues/15588

Description of changes: Added a flag to indicate that the rules are changed without file upload and are mentioned in SR description.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

kialj876 commented 1 year ago

are we sure we don't want to include the SR description in the alteration? Or maybe the SR filing id? -- I don't know the resolution flow well enough to have a solid opinion

ritvick commented 1 year ago

Hi @kialj876 SR filing is a special type of filing which takes multiple filings along with it. A SR filing essentially is SR + CN or SR + Alteration or SR + CN + Alteration. SR: https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/special_resolution.json -> resolution field is description CN: https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/change_of_name.json Alteration: The change we made in this file.