bcgov / business-schemas

Manages the JSONSchemas for the BCRegistry Legal Filings.
Apache License 2.0
4 stars 35 forks source link

18537 Amalgamation application schema #151

Closed chenhongjing closed 9 months ago

chenhongjing commented 9 months ago

Issue #: /bcgov/entity#18537

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

argush3 commented 9 months ago

do we need to support name translations like IA filing?

image

severinbeauvais commented 9 months ago

do we need to support name translations like IA filing?

Yes, good catch!

argush3 commented 9 months ago

You will need to update filing.json too.

https://github.com/bcgov/business-schemas/blob/31e9a18ecc8dcd4a0598e9123a77fdcad6076cb6/src/registry_schemas/schemas/filing.json

image