bcgov / business-schemas

Manages the JSONSchemas for the BCRegistry Legal Filings.
Apache License 2.0
5 stars 35 forks source link

11912 Add incompleteBusinessInfo flag to business schema #93

Closed argush3 closed 2 years ago

argush3 commented 2 years ago

Issue #: /bcgov/entity#11912

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

argush3 commented 2 years ago

Why are we exposing this?

Afaict this is to lock the business, or add an item to the task endpoint.

We can also have filings that remove data (currently) and make a business incomplete. That is handled in the compliance warnings.

The intent was to expose this flag based off of a newly added incomplete_business_info field in the businesses db model. I believe relationships team had planned to populate the Filings UI to do list based off of this flag.

It sounds like we shouldn't do this and just populate the task list from the BE.

Originally, I had also planned to populate the incomplete_business_info field when via the SP/GP data load pipeline. I think from your comments maybe the check should be done dynamically by the api so we can handle the cases where filings make a business incomplete. In which case the incomplete_business_info field in the db is not required.

Will ping you directly in RC to sort out the details.

argush3 commented 2 years ago

closing as this functionality will be achieved through the use of the existing complianceWarning property on the business object.