Spurious happo diffs

[dleard]

The following happo diffs were causing issues in CI by flip-flopping and have been commented out:

Emisisons intensity report form - with errors:

• flip-flopping the page diff on submit button being disabled / not disabled. We probably need to wait for a mutation hook to finish in the test.

Index.spec - renders the IA-specific unfilled project forms:

• same problem as above with the EI Report form

create-subsequent-project-revision.spec - displays updated forms in a project revision/amendment:

• Sometimes renders the down carats, sometimes doesn't. Likely the same issue as the previous two, needing to wait for a query/mutation to finish.

IA Project funding agreement Form - with errors:

• Sometimes the Total Payment Amount to Date is $0.00 and sometimes it says "field cannot be calculated due to a lack of information"

After upgrading Cypress to version 12, we get happo diffs on many pages mainly on Safari and Edge browsers. this diff is mainly around some texts on some pages. an example:

Dev checklist:

• uncomment the incriminating diffs and run them through CI
• verify that they are still an issue
• one possibility for the last issue could be happo-cypress package that is using cypress 10.

[BCerki]

Lindsay, there's nothing to see in dev on this one

[LindsayMacfarlane]

Awesome - thanks @BCerki ! We can probably move into Accepted by PO/Dev column

[BCerki]

This is still a problem, e.g. this report

[BCerki]

Commented out problem diffs in /home/briannacerkiewicz/cas-cif/app/cypress/integration/cif/project-revision/index.spec.js:

• cy.happoAndAxe("Project budgets Form", "empty", "main");
• // cy.happoAndAxe( // "Emissions intensity report Form", // "with errors", // ".error-detail" // );

[pbastia]

An avenue to explore: we use cypress 12, but the happo package wants cypress 10

[BCerki]

If we decide to address this by removing screenshots, I'd suggest adding some cypress assertions for calculated values. Sometimes happo is the only thing that catches changes to the calculations that use values from multiple forms

[pbastia]

idea: remove iOS browsers from happo, they generate spurious diffs after validating the user percentage with our analytics