bcgov / cas-cif

CleanBC Industry Fund project
Apache License 2.0
6 stars 2 forks source link

As a CIF administrator, I want to see a cleaner diff section in Amendments/General Revisions, so that I the clearer context of the changes is hidden but easily accessible #1573

Open nanyangpro opened 1 year ago

nanyangpro commented 1 year ago

Description:

As outcome of #1523, this is a cleaner version of #1569 preferred by users where all contextual/help text of why the user sees a certain change to a field which they didn't make is hidden behind a hover over tooltip.

This design will offer better readability allowing the user to focus on the changes they made while the context of the changes is still easily accessible.

- Design (Cleaner Version)

Acceptance Criteria:

Given I am a CIF Admin When I check the "Forms updated" section to see the changes in an Amendment or a General Revision Then I see the field name: Not entered / Not calculated / value (before) -> value (after) with a tooltip icon instead of the contextual help text

Given I am a CIF Admin When I hover over a tooltip icon next to a changed field Then I see the hidden contextual help text (implemented in #1569)telling why this change shows without the user manually making it

Development Checklist:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

Notes:

-

nanyangpro commented 1 year ago

AC was drafted, pending further refinements and Dev Checklist from the developers. Happy to provide clarifications.

Sepehr-Sobhani commented 1 year ago

Is tooltip implementation also part of this card? shouldn't we have a separate card for that?

pbastia commented 1 year ago

see #1270

nanyangpro commented 1 year ago

@pbastia: To be discussed in Backlog Refinement May 2.

BCerki commented 1 year ago

1569 is probably going to split out the contextual help AC, so this ticket could become the entire implementation of contextual help

BCerki commented 1 year ago

Contextual help text may not be implemented in https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1569. If it's not implemented, this ticket can implement the help text directly into the tooltips (will need to add what the text is supposed to be in this ticket's description)

nanyangpro commented 1 year ago

1742 was create as a stop gap for #1573 & #1575. @dleard

pbastia commented 1 year ago

At this point this is a lot of work for value that hasn't been quite proven given #1742. I suggest iceboxing

nanyangpro commented 1 year ago

Good call, @pbastia - This ticket only makes sense when #1569 is in place. Given #1742 was suggested as a stop gap solution for #1569. This ticket (#1573) can be iceboxed.