bcgov / cas-cif

CleanBC Industry Fund project
Apache License 2.0
6 stars 2 forks source link

CIF: Bug: Operation column is confusing and shows archived records on the project attachment view page #1922

Closed pbastia closed 1 month ago

pbastia commented 3 months ago

Describe the Bug:

A confusing "Operation" column shows for attachments, where "Archive" operations are also shown in the attachments table when viewing a project. I suggest removing that column altogether @dleard @patriciarussellCAS @Sepehr-Sobhani @BCerki

Probability (how likely the bug is to happen, scored from 1-5): 5 Effect (how bad the bug is when it does happen, scored from 1-5): 2

Steps to reproduce the behaviour: View the attachments page for a project where attachments were just added and removed as part of the latest revision/amendment

Screenshots:

image

Additional information:

dleard commented 3 months ago

I found the PR where this was added and it was an intentional change. Are we sure we want to remove it?

pbastia commented 3 months ago

@dleard I think in this particular spot (the actual attachment table) this causes confusion when looking at the current attachments for a project. The feature will stay active and useful for the diff before a user submits a revision, it's using the same component.

patriciarussellCAS commented 3 months ago

Thanks for taking this on guys! Do we need to assign someone to the ticket, or at this point does it matter? @pbastia

patriciarussellCAS commented 2 months ago

Is someone able to point to a specific project in the Test enviro where I could see this fix? Every project I click on has zero attachments!

And just to confirm - the intended outcome here is that we should no longer see "archive" files in the list, correct? Also have we clarified for them what the difference between "create" and "update" is under the operation column? That isn't clear. @pbastia & @Sepehr-Sobhani

patriciarussellCAS commented 1 month ago

I was able to recreate this and confirmed that deleted attachments are no longer visible in the list.

@pbastia - not sure if this is a separate issue but wondered why the file "type" for my word doc attachment looks like this? Is it meant to be so lengthy, or should it just say "Word" or "Document"?

Image

pbastia commented 1 month ago

@patriciarussellCAS this is the mime-type that the system reports, it's actually correct. If we want a better readout we would need to build that in

patriciarussellCAS commented 1 month ago

Next step: deploy to test - let CIF internal team know - have them test it, then if it's good, push to Prod.

patriciarussellCAS commented 1 month ago

Deployed to Prod