bcgov / cas-ggircs

Climate Action Secretariat's Greenhouse Gas Industrial Reporting and Control System
Apache License 2.0
3 stars 4 forks source link

As an analyst I want to see a calculated quantity for emissions using AR5 GWP values so that I can compare older years values with the updated GWP #516

Closed dleard closed 12 months ago

dleard commented 1 year ago

A new column in the swrs.emission table is required to allow analysts to see what the calculated quantity for previous years would be according to the updated AR5 GWP values .

As an analyst When I am querying the swrs.emission data in Metabase I can see an AR5 calculated quantity value which is calculated by quantity x gwp(AR5 value)

Development steps:

dleard commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @BCerki @gurjmatharu @JoshLarouche @sam-warren @Sepehr-Sobhani

dleard commented 1 year ago

Please add your planning poker estimate with Zenhub @mikevespi

pbastia commented 1 year ago

@BCerki the ar5_calculated_quantity column is null in Metabase-dev, when the quantity is filled out. I also can't see a swrs_parameters schema in the swrs database. Maybe something went wrong in the deploy to -dev?

dleard commented 1 year ago

@BCerki @pbastia The dev data is entirely synthetic, created with inserts rather than parsed via the ETL (where the ar5 calculation is done) so the calculated field will always be empty in dev. The pgTap tests covered the load() function and passed, I suggest deploying this to test where I believe the ETL does run over a few reports and the value should show up there.

pbastia commented 1 year ago

Aaaah thanks for clarifying. I thought we had fake XML that got parsed. Seems like we can't test in dev then