bcgov / cas-registration

A web app for Registration in OBPS under the Clean Growth branch
Apache License 2.0
1 stars 1 forks source link

Add model tests for `FacilityOwnershipTimeline`, `OperationOwnershipTimeline` and `Event` [6] #1775

Open Sepehr-Sobhani opened 3 months ago

Sepehr-Sobhani commented 3 months ago

Description of the Tech Debt

We developed a few new data models in the recent mini-spike PR at https://github.com/bcgov/cas-registration/pull/1748. However, we didn't include tests for these data models because we aimed to visualize them in Metabase quickly. This ticket addresses this and adds tests for the newly created data models.

New models WO test:

Tech Debt Triage

The purpose of our technical debt triage process is to analyze technical debt to determine risk level of the technical debt and the value in tackling that technical debt.

Risk Value Scoring:

Level Value
High 3
Medium 2
Low 1
Technical Debt - Risk Types Level Value
Business Area Risk - Risk of business area visibility / damage to user experience 1
Developer Fault Risk - How likely will this tech debt cause a future error related to coding on top of it 1
System Fault Risk - Risk of system errors or application downtime
Time Scale Risk - Compound risk effect if left alone. How much more difficult to fix or dangerous will this become over time? 2
Time Sink Risk - How much will this tech debt slow the development process down 1
TOTAL SCORE: 6
Sepehr-Sobhani commented 1 month ago

Update: FacilityOwnershipTimeline and OperationOwnershipTimeline models have new names now. Event data model is now an abstract data model and doesn't need model tests.