bcgov / cas-registration

A web app for Registration in OBPS under the Clean Growth branch
Apache License 2.0
1 stars 1 forks source link

Reg\Register an Operation\Page "Registration Purpose"- External user can register the operation #1899

Closed zoeyli-46 closed 1 week ago

zoeyli-46 commented 2 months ago

Description:

As an industry user, given that the operation has been added to my operator, I can register the operation for IRC approval.

Acceptance Criteria:

Given that I am on the Operations grid and clicked Add and Register an Operation, or if I am on the Registration dashboard (or main BCIERS dashboard) and clicked Register an Operation, Then I am brought to the first page of the Register an Operation form: the Operation Information page https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=10222-8&t=rBpJCzhxRzIMrjwm-4

Given that I opened the dropdown menu, The options are presented in the following order:

Restrictions User can only pick 1 option

Given that I select the Regulated Operation, Reporting Operation, New Entrant or Opt-in as the registration category Then the page shows the form field for Regulated products

~Given that I select opt in or new entrant, then an extra bubble appears in the stepper as step 4, after facility information~ pulled out into tickets #1906 and #1952

Development Checklist:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

Notes:

Dependencies

BCerki commented 1 month ago

@andrea-williams , in 1952 the registration purpose and operation are many-to-many; in this ticket it's one-to-many. Thoughts? I've done it as one-to-many in https://github.com/bcgov/cas-registration/pull/1990/files but I think many-to-many might actually make more sense

BCerki commented 1 month ago

@andrea-williams , in 1952 the registration purpose and operation are many-to-many; in this ticket it's one-to-many. Thoughts? I've done it as one-to-many in https://github.com/bcgov/cas-registration/pull/1990/files but I think many-to-many might make more sense

@andrea-williams is on vacation! @Sepehr-Sobhani , thoughts?

Sepehr-Sobhani commented 1 month ago

I reviewed the PR for this ticket and I believe your implementation is correct. With this approach, each operation can have multiple purposes, and we can query all purposes of an operation using the related_name. Another way to implement this would be to have a ManyToMany field in the RegistrationPurpose data model, but on the front end, we only allow for one option to choose from. This approach eliminates the need to use TimeStampedModel for the RegistrationPurpose data model.

shon-button commented 1 week ago

@patriciarussellCAS

Note: 'Register an Operation` a multi-step process, reachable at: https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/registration/register-an-operation

patriciarussellCAS commented 1 week ago

Review Note: