Reg\Register an Operation\Page "Operation Information\Opted-in Operation" - External user can register the operation

andrea-williams commented 3 months ago

Dependencies

Blocked by #1899
Blocked by #2133
Blocking https://github.com/bcgov/cas-registration/issues/2094

Description:

Brief description of the work involved, including any user research context or key decisions.

In Registration workflow mode, wireframe

Acceptance Criteria:

Given an authenticated external user has selected "Opted-in Operation" as the purpose of registration in the Registration workflow Then they get an extra step at step 3 (after facility information) called Opt-In Application And they see this form

Given an authenticated external user has selected "Opted-in Operation" as the purpose of registration in the Registration workflow When they get to the "Operation Information" step of the Registration form Then they see this And when they click the "Save and Continue" button, the data they input is saved to our database

Development Checklist:

Create new data model Opted In Operation:

[x] FK reference to operation ID
[x] json that will have Yes/No answers to the following questions

Does this operation have emissions that are attributable for the purposes of section 3 of the Act?
Is this operation an electricity import operation?
Is this operation a part of a single facility operation or a linear facilities operation?
Does this operation have emissions that are attributable for the purposes of section 6 of the Act?
Is this operation's primary economic activity classified by the following NAICS codes: 11, 22, or 562?
Does this operation produce a regulated product listed in Table 1 of Schedule A.1 of the GGERR?
Is this operation capable of fulfilling the obligations of a reporting operation and a regulated operation under the Act and the regulations?
Will the operator notify the Director as soon as possible if this operation ceases to meet any of the criteria for the designation of the operation as a reporting operation and a regulated operation?

[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

shon-button commented 3 months ago

@andrea-williams For your consideration, to enhance clarity and robustness; perhaps, it would be beneficial to reference steps by their specific names rather than their numerical order. For instance, instead of this detail, "When they get to the 4th step of the Registration form," it might be more clear as this detail, "When they get to the Operation Information step of the Registration form."

Sepehr-Sobhani commented 2 months ago

@andrea-williams May I move the last AC of this ticket to a separate ticket and block it with this ticket? I want to do this to avoid creating a monster PR.

andrea-williams commented 2 months ago

@andrea-williams May I move the last AC of this ticket to a separate ticket and block it with this ticket? I want to do this to avoid creating a monster PR.

@Sepehr-Sobhani certainly!

Sepehr-Sobhani commented 2 months ago

@andrea-williams Created this ticket: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=&pane=issue&itemId=74955567 and I gave it a 3.

shon-button commented 2 months ago

@patriciarussellCAS

Note: 'Register an Operation` a multi-step process, reachable at: https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/registration/register-an-operation

hannavovk commented 2 months ago

This one doesn't seem to be working in dev - despite selecting "opt-in", I get the "new entrant" workflow. The same happens if I select any other registration purpose. (@Sepehr-Sobhani, @patriciarussellCAS )

hannavovk commented 2 months ago

Also, the 'steps' at the top show the "new entrant application" step before any registration purpose is selected. (cc: @Sepehr-Sobhani, @patriciarussellCAS )

Sepehr-Sobhani commented 2 months ago

Also, the 'steps' at the top show the "new entrant application" step before any registration purpose is selected. (cc: @Sepehr-Sobhani, @patriciarussellCAS )

Yes, the registration purpose is hard coded for now and we have captured the tasks to resolve this issue in this ticket: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=purpose&pane=issue&itemId=76712500

patriciarussellCAS commented 1 month ago

Hey @Sepehr-Sobhani could you walk me through this one? In dev, when I select opted-in operation for purpose I'm still not seeing additional data fields in the operation information section for opt-ins. I may be doing something wrong though!

Sepehr-Sobhani commented 1 month ago

Hey @Sepehr-Sobhani could you walk me through this one? In dev, when I select opted-in operation for purpose I'm still not seeing additional data fields in the operation information section for opt-ins. I may be doing something wrong though!

Hey Patricia! The registration purpose is currently hard coded, so we won't be able to see this in dev until this ticket is merged. However, I can guide you through it using my local environment if that works for you?!

patriciarussellCAS commented 1 month ago

Thanks Sepehr. #2133 is in pending PO approval...but maybe it hasn't been merged yet? Perhaps we can connect on this tomorrow if you're around :)

Sepehr-Sobhani commented 1 month ago

Aw, sorry, I didn't notice it had been merged! I tried this feature and was able to get to the 'opted-in' page in Dev.

Screenshot 2024-09-19 at 3 53 10 PM

I can guide you through this tomorrow if you want.

patriciarussellCAS commented 1 month ago

I was able to review this in Dev and confirm that it works as intended.

My review notes:

Do we need to reject anyone who selects "NO" to any of the questions in the Opt-in Application form? Or do we allow them to continue through to the end of registration?
Follow-up question for BA: How/when are they reviewing the answers in the Opt-in Application form?

bcgov / cas-registration