bcgov / cas-registration

A web app for Registration in OBPS under the Clean Growth branch
Apache License 2.0
1 stars 1 forks source link

Can't submit the facility form for an LFO [8] #2203

Open BCerki opened 1 week ago

BCerki commented 1 week ago

Describe the Bug:

When you click "Save and Continue," the button goes grey but you're never redirected to the next step: https://www.loom.com/share/dab33f8a692f470599df2bd106433e26. Operation 2 is our mock LFO.

SFOs seem to work fine.

Probability (how likely the bug is to happen, scored from 1-5): 5? (For example, probability of 5 is something like "it happens to all users every time they log in." Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Effect (how bad the bug is when it does happen, scored from 1-5): 3 (For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected." Effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

Screenshots:

Additional information:

marcellmueller commented 6 days ago

I looked into this because it was previously working and it's the small bugfix for the DataGrid empty rows that caused this to break. I'm not exactly why this one line fix caused it though from my work on the Facility DataGrid issue I know that the router.push in the form page change sometimes causes the DataGrid to refresh due to the query param change and stops the page transition.

Edit: It works again if we undo this commit. Not saying we should undo it as it fixes another bug, though it might be helpful to whoever picks up this issue! https://github.com/bcgov/cas-registration/commit/4a9daadc3be3cfef9aca33596bf879b63b5eaf48