Review implementation of conditional RJSF

bcgov / cas-registration

A web app for Registration in OBPS under the Clean Growth branch

Apache License 2.0

1 stars 1 forks source link

Review implementation of conditional RJSF #602

Open dleard opened 7 months ago

dleard commented 7 months ago

We have implemented some logic on how to manipulate data to apply conditional RJSF forms in different ways due to different constraints in the workflows. It would be good to review what's been done & see if there is a best practice or standardized way that we can do this so that we're not re-inventing how this is done in the future.

Things to consider in this ticket:

Should we be saving boolean choices to the db?
Is using a resolver the standard we want to use & determine a standard for cases when a resolver is not possible?
Should checkboxes that determine the pathing in a dynamic RJSF schema be separate components (the checkbox informs the data, but is not part of the data?)

marcellmueller commented 7 months ago

For context this tech debt ticket came about from this discussion about the isUserApplicationLead logic to correctly display the is_user_application_lead checkbox when a user viewed a saved form.

I had tried to do it with a resolver though we didn't have access to the User field as a foreign key unlike a resolver in the User Operator schema so took care of is on the front end. This is not ideal and we should likely try and either save the boolean fields or at least use resolvers and handle it all on the back end (if possible).