bcgov / cas-reporting

This is for the Clean Growth Digital Services team for work related to reporting.
Apache License 2.0
0 stars 0 forks source link

Contribution guidelines for parallel development with Registration #159

Closed pbastia closed 6 months ago

pbastia commented 7 months ago

Description:

A .md file outlining the contribution guidelines for the reporting app. There is just a bit of thinking to do on how exactly this is going to work. The first idea is to merge all the work on a separate giraffe-develop branch, and to rebase that branch as often as possible from the registration official develop

This is experimental, and those guidelines are meant to be adjusted in the future.

Acceptance Criteria:

Given I am a developer on the reporting app When I write code for the app Then I have a list of contribution guidelines

Development Checklist:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

Notes:

-

pbastia commented 7 months ago

@patriciarussellCAS you can see the writeup here https://github.com/bcgov/cas-home/blob/main/docs/giraffeContributionGuidelines.md

patriciarussellCAS commented 7 months ago

Thanks @pbastia - these look good to me. Has a senior dev from Moose had a look as well? It would be nice to have their okay as well, before I close this ticket. Also, is there a place to share this on Scrum team? Or is just in github enough? Thanks!

pbastia commented 7 months ago

flagging @dleard and @andrea-williams for an extra review :)