search

bcgov / cas-reporting

This is for the Clean Growth Digital Services team for work related to reporting.
Apache License 2.0
0 stars 0 forks source link

Post giraffe-develop merge cleanup #215

Closed mikevespi closed 4 days ago

mikevespi commented 2 months ago

Describe the task

In order to keep the branch used to merge Giraffe work into develop isolated, the comments made in that PR are yet to be addressed. We need to make the necessary changes, and remove any references to the giraffe-develop that made it to the code (e.g. in git workflows).

Acceptance Criteria

Additional context

More changes that need to be made now that we've merged may emerge as this work is done. If they are small enough to include in this work, feel free to do so. Otherwise write a new ticket for it.

Blocked By

232

pbastia commented 2 months ago

I wonder how much of this is left. We should definitely do it before a lot of code is built on top

joshgamache commented 1 month ago

Soft-blocked by #232. Since that ticket will be rewriting/refactoring a large block of CI, it might inherintly take care of pieces of this ticket. Review this ticket after completing 232.

BallardRobinett commented 3 weeks ago

Removing use nx affected, add tags, and refactor filename AC since they are included in this card: https://github.com/bcgov/cas-reporting/issues/232

BallardRobinett commented 2 weeks ago

to confirm, I am totally removing the deploy process to cif-tools that giraffe-dev was using? @pbastia @joshgamache

pbastia commented 2 weeks ago

Correct @BallardRobinett ! Our frontend pods now share the same API/database, so there is no point in a separate deployment anymore