bcgov / cas-reporting

This is for the Clean Growth Digital Services team for work related to reporting.
Apache License 2.0
0 stars 0 forks source link

Replace Unit & fuel free-form strings with enums / calculated values in the form schemas #346

Closed dleard closed 1 month ago

dleard commented 2 months ago

Because we were missing some clarity initially, we created our schemas with some free-form fields text for the units & fuels objects. We have the proper requirements / information around these now and can update those to be enum dropdowns / calculated non-editable fields where appropriate.

Todo:

EDIT: It sounds like IRC is going to send us an exhaustive list of fuels along with their respective classifications. We should add the classifications from that list & check the list of fuels we currently have in the database with what is in the list we receive from IRC.

dleard commented 2 months ago

@patriciarussellCAS I remember you noted that some fields in the Units/Fuel sections didn't conform to the design (text fields where we should have dropdowns). We were waiting on some clarity around those fields before updating them, we now have that understanding & this ticket is to address that and make those changes from text fields to dropdowns with pre-defined options.

dleard commented 2 months ago

@patriciarussellCAS For reviewing this one: Any of the GSC activity pages will work, since they have both units & fuels. The visible change is that the unit type & fuel name fields are now dropdowns with pre-defined values to select from

patriciarussellCAS commented 2 months ago

My review:

dleard commented 2 months ago

I split some of this work out into #349. Once that one is in, units & classification will be read-only fields that are populated when a fuel selection is made. It should also fix the bug in #303 as I've updated all the schemas & uiSchemas in #349 as well