bcgov / citz-imb-staff-purchase-reimbursement

Citizen Services Capstone Project A for 2023

Apache License 2.0

4 stars 1 forks source link

SPR-156 File Loading Optimization #70

Closed dbarkowsky closed 1 year ago

dbarkowsky commented 1 year ago

Description

This PR includes the following proposed change(s):

Change in how files load. Previously they were loaded when the record was loaded. This could get slow with many files. Now only the metadata loads, but the file isn't pulled from the API until a download is requested.
Added a new route for file retrieval.
Changed the way the FileUploader component renders
Changed how the patch controller handles incoming purchases and approvals changes.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change
[ ] Dependencies added/removed

Aspect(s) of Project Affected

[x] Frontend
[x] API
[ ] Database
[ ] Workflows
[x] Documentation

Best Practices Checklist

[x] I have performed a self-review of my own code
[x] My code follows the Airbnb React Style Guidelines
[x] Documentation has been updated to reflect my changes
[x] New and existing tests pass locally with my changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Tested locally.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 5ce4bc51 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	4
Duplication	4

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.