bcgov / citz-imb-staff-purchase-reimbursement

Citizen Services Capstone Project A for 2023

Apache License 2.0

4 stars 1 forks source link

SPR-172 complete but not saved popup #86

Closed dbarkowsky closed 1 year ago

dbarkowsky commented 1 year ago

Builds off SPR-170. Please review that before.

Description

This PR includes the following proposed change(s):

Added a prompt for when files have not been saved. This is really only important to the admins.
Adjusted how prompts are shown, allowing for multiple prompts, but not all at once.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change
[ ] Dependencies added/removed

Aspect(s) of Project Affected

[x] Frontend
[ ] API
[ ] Database
[ ] Workflows
[ ] Documentation

Best Practices Checklist

[x] I have performed a self-review of my own code
[x] My code follows the Airbnb React Style Guidelines
[x] Documentation has been updated to reflect my changes
[x] New and existing tests pass locally with my changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Tested through manual use of frontend.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 8a9bc48d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.