BETA: Preview button on Resource not producing the expected results

ghost commented 3 years ago

From Colin Newell:

Resource: https://beta-catalogue.data.gov.bc.ca/dataset/parcelmap-bc-parcel-polygons/resource/ab87d159-a059-4dbf-9da5-221c37e5f63e

Press “preview” to get error message.

From: DataBC CITZ:EX Data@gov.bc.ca Sent: July 20, 2021 6:43 AM To: Newall, Colin G CITZ:EX Colin.Newall@gov.bc.ca Cc: CITZ DPD DSS Data Discovery Services DPDDSDDS@Victoria1.gov.bc.ca Subject: RE: BETA - catalogue

New Catalogue looks awesome! Great work!

I clicked “preview” for the PMBC record and this error appeared – is it supposed to work?

BETA SMK Error.jpg

Thank you,

Colin Newall Team Lead, Data Management

joe-taylor commented 3 years ago

Although it's possible the map preview isn't supposed to work for the example record, as that record relies on the order filler interface, I can see that the issue described above occurs whenever an invalid lat,lon,zoom triplet is provided through the smk-center parameter of the preview page.

https://bcdc-smk.data.gov.bc.ca/?smk-center=,, - doesn't work, and the infinite tiles message is in the JS console
https://bcdc-smk.data.gov.bc.ca/?smk-center=0,0,0 - works

Updating the code so as to not pass values which will trigger the above error is a simple path forward, but with the status quo it's possible that preview windows will in many cases load a regular blank map with no extra layers, so I'd like to investigate further to get a better understanding of the problem and alternate solutions.

joe-taylor commented 3 years ago

Per conversation offline, proceeding with a fix to simply remove the error message. Logic to enable/disable the preview button depending on whether a preview is available is TBD via another ticket post MVP.

joe-taylor commented 3 years ago

With the way the preview button is engineered currently, logic to disable it where it is not applicable is relatively straightforward to implement, at least in the majority of cases. I've written some code to accomplish this and can send it through to code review if the team is amenable.

alixcote commented 3 years ago

Annika/Joe to follow up on logic

joe-taylor commented 3 years ago

We've decided to move this forward but will revisit whether some preview windows are hidden that shouldn't be at the UAT stage.

joe-taylor commented 3 years ago

Feature to disable the preview button for records it doesn't apply for is ready for code and UAT review.

joe-taylor commented 3 years ago

The latest changes haven't been merged to toyger yet.

ghost commented 3 years ago

Selecting the Preview Button on each Resource by Resource Data Type

Testing - Resource Data Type = arcgis_rest

https://toyger.data.gov.bc.ca/dataset/stand-level-biodiversity-frep-data-sampling-up-to-2019-
Results: no error, but nothing displayed

Testing - Resource Data Type = csv

https://toyger.data.gov.bc.ca/dataset/bc-geographic-warehouse-object-structure-change-history
Results: no error, but message displayed

Testing - Resource Data Type = e00 (mapped to Other)

https://toyger.data.gov.bc.ca/dataset/bc-geographic-warehouse-object-structure-change-history
Results: no error, but message displayed

Testing - Resource Data Type = fgdb (mapped to Other)

https://toyger.data.gov.bc.ca/dataset/internet-connectivity-in-relation-to-b-c-health-geographies-map
Results: no error, but message displayed

Testing - Resource Data Type = geojson

https://toyger.data.gov.bc.ca/dataset/translink-major-road-network
Results: no error, but nothing displayed

Testing - Resource Data Type = html

https://toyger.data.gov.bc.ca/dataset/forest-inventory-ground-sample-data-and-interactive-map
Results: no error, but nothing displayed

Testing - Resource Data Type = json

https://toyger.data.gov.bc.ca/dataset/howe-sound-cumulative-effects-project-area-data-howe-sound-cumulative-effects
Results: no error, but nothing displayed

Testing - Resource Data Type = kml

https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map
Results: map displayed and View in iMapBC button

Testing - Resource Data Type = kmz

https://toyger.data.gov.bc.ca/dataset/meteorological-monitoring-sites
Results: map displayed and View in iMapBC button

Testing - Resource Data Type = Multiple

https://toyger.data.gov.bc.ca/dataset/archaeology-known-sites
Results: no error, but message displayed

Testing - Resource Data Type = openapi-json

https://toyger.data.gov.bc.ca/dataset/common-document-generation-service-api
Results: no error, but message displayed

Testing - Resource Data Type = other

https://toyger.data.gov.bc.ca/dataset/muskwa-kechika-report-to-the-premier-and-public-of-bc-web-viewer-2018
Results: no error, but message displayed

Testing - Resource Data Type = pdf

https://toyger.data.gov.bc.ca/dataset/metadata-for-k-to-12-socio-economic-status-ses-index
Results: no error, but message displayed

Testing - Resource Data Type = shp

https://toyger.data.gov.bc.ca/dataset/hexagonal-polygon-grid-resolution-4096-hectare-cell
Results: no error, but nothing displayed

Testing - Resource Data Type = txt

https://toyger.data.gov.bc.ca/dataset/urgent-and-primary-care-centres
Results: a map was displayed (data issue?)

Testing - Resource Data Types = wms

https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map
Result: map displayed and View in iMapBC button

Testing - Resource Data Type = xls

https://toyger.data.gov.bc.ca/dataset/bc-finance-budget-2019
Results: no error, but message displayed

Testing - Resource Data Type = xlsx

https://toyger.data.gov.bc.ca/dataset/bc-finance-budget-2019
Results: no error, but message displayed

Testing - Resource Data Type = xml

https://toyger.data.gov.bc.ca/dataset/bedrock-geology
Results: a map was displayed (data issue?)

Testing - Resource Data Type = zip

https://toyger.data.gov.bc.ca/dataset/province-of-british-columbia-boundary-terrestrial
Results: no error, but nothing displayed

Action thoughts:

Confirm the issues noted as data issue
Discuss how to handle the ability to select Preview link when nothing is displayed

joe-taylor commented 3 years ago

Please note that QA was undertaken before code changes were pushed through to toyger so while there may be useful information about errors overlooked before this is not a review of recent work completed.

joe-taylor commented 3 years ago

This has been migrated to toyger but you may need to clear your browsers cache or hold shift and click reload to get the changes to show up.

ghost commented 3 years ago

Not logged in to do this testing.

Resource Data Type = _arcgisrest (Geographic Data) Dataset: https://toyger.data.gov.bc.ca/dataset/stand-level-biodiversity-frep-data-sampling-up-to-2019- Resource: https://toyger.data.gov.bc.ca/dataset/stand-level-biodiversity-frep-data-sampling-up-to-2019-/resource/060981fa-33bc-4383-b598-d844e205023e _[Preview]_button enabled Results:

Resource Data Type = csv Dataset: https://toyger.data.gov.bc.ca/dataset/hunter-sample-moose-survey-estimates-1976-to-current Resource: https://toyger.data.gov.bc.ca/dataset/hunter-sample-moose-survey-estimates-1976-to-current/resource/fdec42f4-4883-43f4-95af-8a8fcb4ba504 _[Preview]_button disabled Results:

Resource Data Type = e00 (mapped to other) Dataset: https://toyger.data.gov.bc.ca/dataset/bc-canadian-aquatic-biomonitoring-network-cabin-sites-and-models-web-app Resource: https://toyger.data.gov.bc.ca/dataset/bc-canadian-aquatic-biomonitoring-network-cabin-sites-and-models-web-app/resource/151c7801-a738-48bf-8fce-c9106d694575 [Preview] button disabled Results: as expected

Resource Data Type = fgdb (mapped to other) Dataset: https://toyger.data.gov.bc.ca/dataset/internet-connectivity-in-relation-to-b-c-health-geographies-map Resource: https://toyger.data.gov.bc.ca/dataset/internet-connectivity-in-relation-to-b-c-health-geographies-map/resource/ca6b7e94-c9d6-4654-9cf9-b26bce39ec37 [Preview] button disabled Results: as expected

Resource Data Type = geojson Dataset: https://toyger.data.gov.bc.ca/dataset/translink-major-road-network Resource: https://toyger.data.gov.bc.ca/dataset/translink-major-road-network/resource/f2cbf48b-3217-4dd3-a2b1-97709467cee0 [Preview] button enabled Results:

Resource Data Type = html Dataset: https://toyger.data.gov.bc.ca/dataset/forest-inventory-ground-sample-data-and-interactive-map Resource: https://toyger.data.gov.bc.ca/dataset/forest-inventory-ground-sample-data-and-interactive-map/resource/9af955f4-83ba-4b26-a6c5-e9f8dcaec147 [Preview] button disabled Results: as expected

Resource Data Type = json Dataset: https://toyger.data.gov.bc.ca/dataset/howe-sound-cumulative-effects-project-area-data-howe-sound-cumulative-effects Resource: https://toyger.data.gov.bc.ca/dataset/howe-sound-cumulative-effects-project-area-data-howe-sound-cumulative-effects/resource/8eca5485-8f58-4665-94fd-52ba5d0959de [Preview] button disabled Results: as expected

Resource Data Type = kml Dataset: https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map Resource: https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map/resource/263926a8-c3db-4480-ac90-b52067f9e42e [Preview] button enabled Results:

Resource Data Type = kmz Dataset: https://toyger.data.gov.bc.ca/dataset/meteorological-monitoring-sites Resource: https://toyger.data.gov.bc.ca/dataset/meteorological-monitoring-sites/resource/a2085229-e5f5-4c21-a5ec-dcf4867b6e02 [Preview] button enabled Results:

Resource Data Type = mulitple (Geographic Data) Dataset: https://toyger.data.gov.bc.ca/dataset/archaeology-known-sites Resource: https://toyger.data.gov.bc.ca/dataset/archaeology-known-sites/resource/548bc387-0726-4036-bf09-f0cb067e0774 [Preview] button enabled Results:

QUESTION: Should [Preview] button be disabled for this Resource Data Type? (@TerryLanktree , @annikaLiving , @joe-taylor , @adodge-bcg )

Resource Data Type = openapi-json Dataset: https://toyger.data.gov.bc.ca/dataset/common-document-generation-service-api Resource: https://toyger.data.gov.bc.ca/dataset/common-document-generation-service-api/resource/3ab4504d-7647-427a-9f0d-7c1f75b6da90 [Preview] button disabled Results: as expected

Resource Data Type = other (Application) Dataset: https://toyger.data.gov.bc.ca/dataset/muskwa-kechika-report-to-the-premier-and-public-of-bc-web-viewer-2018 Resource: https://toyger.data.gov.bc.ca/dataset/muskwa-kechika-report-to-the-premier-and-public-of-bc-web-viewer-2018/resource/4f12e518-5127-4a2d-9f55-a1b545019bf0 [Preview] button disabled Results: as expected

Resource Data Type = other (Geographic Data) Dataset: https://toyger.data.gov.bc.ca/dataset/census-profile-key-facts-for-bc-census-divisions-2016-census Resource: https://toyger.data.gov.bc.ca/dataset/census-profile-key-facts-for-bc-census-divisions-2016-census/resource/765dbbf3-5c30-4b45-9ab3-90d503f15c6b [Preview] button enabled Results:

Resource Data Type = pdf Dataset: https://toyger.data.gov.bc.ca/dataset/graduation-assessments Resource: https://toyger.data.gov.bc.ca/dataset/graduation-assessments/resource/be0e7d05-11ba-4883-a57a-900a0c3ed5e6 [Preview] button disabled Results: as expected

Resource Data Type = shp Dataset: https://toyger.data.gov.bc.ca/dataset/hexagonal-polygon-grid-resolution-4096-hectare-cell Resource: https://toyger.data.gov.bc.ca/dataset/hexagonal-polygon-grid-resolution-4096-hectare-cell/resource/5b3cd331-7b22-47b0-9397-57833b33941d [Preview] button enabled Results:

QUESTION: When I filtered by shp, the result set looks confusing. I am seeing more than that type returned. I also noticed that there is no way for me to provide the link to the result set like I can in Production. I will add this an enhancement. (@TerryLanktree , @annikaLiving , @joe-taylor , @adodge-bcg )

Resource Data Type = txt (Geographic Data) Dataset: https://toyger.data.gov.bc.ca/dataset/urgent-and-primary-care-centres Resource: https://toyger.data.gov.bc.ca/dataset/urgent-and-primary-care-centres/resource/5c1bd7aa-48f1-403a-aa6d-aae08e971d33 [Preview] button enabled Results:

QUESTION: Is this correct? Could be a data migration issue. Why would a txt resource Geographic Data resource and not a Tabular Data. (@TerryLanktree , @annikaLiving , @joe-taylor , @adodge-bcg )

Resource Data Type = wms (Webservice/API) Dataset: https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map Resource: https://toyger.data.gov.bc.ca/dataset/natural-disturbance-type-map/resource/3a61e42c-18dc-4bcb-977d-479a9e5e945a [Preview] button enabled Results: