search

bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension
http://catalogue.data.gov.bc.ca
GNU Affero General Public License v3.0
24 stars 23 forks source link

All attribution links should open in new browser tab - including Leaflet #124

Open gjlawran opened 8 years ago

gjlawran commented 8 years ago

Leaflet attribution hyperlink used in Data Explorer web map should open in a new tab - rather than within the current iFrame. This is an attribution link that is built into default Leaflet -not added through configuration - so a modification to either Leaflet or recline.js may be required to facilitate.

jrods commented 8 years ago

@gjlawran can you provide an example resource that does this?

gjlawran commented 8 years ago

Visit this resource https://catalogue.data.gov.bc.ca/dataset/bc-public-libraries-systems-branches-and-locations/resource/b6a28bfb-580b-4662-9f00-f7189d52fbe6 Select the Map tab in the Data Explorer Select the Leaflet attribution hyperlink.

jrods commented 8 years ago

The Leaflet attribution link is added by the library itself. The change would have to be done to the vendor file, leaflet-src.js the reclineview ext in ckan.

kfishwick commented 8 years ago

This is not part of the core behaviour and is difficult to change (see above details from @jrods). I would recommend revisiting this requirement & deciding if it is really necessary.

Mbrownshoes commented 8 years ago

Agreed, we can delay for now.

jeff-at-h3 commented 6 years ago

is this still a valid issue? needs to be determined before we can estimate

Mbrownshoes commented 6 years ago

@jeff-at-h3 Yes, this is still a valid issue. leaflet attribution doesn't open in new window: https://catalogue.data.gov.bc.ca/dataset/bc-public-libraries-systems-branches-and-locations-2016/resource/b6a28bfb-580b-4662-9f00-f7189d52fbe6?view_id=3353cdb5-ef17-4f83-9bf1-c67bfdce3912