bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension
http://catalogue.data.gov.bc.ca
GNU Affero General Public License v3.0
24 stars 23 forks source link

UI change for OFI resource creation #312

Closed Mbrownshoes closed 7 years ago

Mbrownshoes commented 7 years ago

A number of editors are having difficulty with the creation of geographic records, following the implementation of the OFI.

Problem Editors are encouraged to start creating metadata records before resources have been configured for download. However, the OFI only auto-creates resources with object names that have been configured for download.

Current workflow When an editor is creating a draft record and they click ‘Add Data’ (after having added an object name), the following is displayed:

image001

Since the object has not been configured for download, the resources can’t be created. Clicking on cancel directs them to the normal resource creation page This is problematic because:

Solution

Editors needs to be able to make geographic records without resources. Thus, when an editor is creating a geographic dataset with an object name that has yet to be configured for download, they should be able to save a record after completing the first record creation page, without having to add data. These draft records should be searchable only for logged in editors of the record's branch.

The allow for this, please Add a ‘Save Dataset’ button at the bottom of the first record creation page which will create the new resourceless dataset.

Mbrownshoes commented 7 years ago

@ll911 @dkelsey a further question is how should the OFI resources get created. It would be nice to have a job that ran nightly and populated resources for objects that have been configured, but there should still be this button on the manage resource page:

screen shot 2017-04-05 at 2 30 05 pm

Except it should say 'Add Geographic Warehouse' resources or something other than 'OFI'. thoughts?

Mbrownshoes commented 7 years ago

@jrods I'm not seeing a 'Save Dataset' button at the bottom of the first page of the geographic create dataset page. Was this feature added?

dkelsey commented 7 years ago

@jrods, @Mbrownshoes and I were chatting about this. We would like screen shot 2017-04-19 at 11 26 01 am to say: Manage BCGW Resources

dkelsey commented 7 years ago

@jrods only Geographic Datasets should be allowed to be created without resources. All other record types should still require at least one resource.

dkelsey commented 7 years ago

@jrods There's an issue with saving metadata records without resource. The Save Dataset button on the first page of the Geographic Dataset creation process works correctly. If you instead press the Next: Add Data button your are taken to the 'Add data to the dataset' page. if you don't add data there is a Previous button.
When I click that i'm taken back to the previous page. Now, clicking the Save Dataset button does not save the dataset. Instead I'm taken to the 'Add data to the dataset' page

We should be able to navigate back to the first page, and click Save Dataset and have the dataset saved without resources. @Mbrownshoes

jrods commented 7 years ago

@dkelsey the reason why that happens is because when you click the 'save dataset' button first, it creates the dataset. So when you go back, the dataset you just created doesn't get deleted or anything, it still exists. Now when you click the 'save dataset' button again it goes the normal route because the dataset exists and uses the normal path for new datasets. The new function that allows for skipping the add data step doesn't consider updating existing datasets, so it takes the path of using the ckan core methods. The dataset still gets saved either way, I know the UX is janky, but changing the workflow for dataset creation moves away greatly from core ckan.

dkelsey commented 7 years ago

@jrods I don't imagine editors will proceed to the "add data page" and "go back" without adding a resource, with any regularity. However, If they make an error or are confused and do so, there is nothing that indicates the record has been saved, and at that point they are caught in a loop where it appears they can't save the record or finish until they add a resource.. I'll leave it as is but I don't like it.

dkelsey commented 7 years ago

Creation of Geographic Datasets works. I created the following without a resource.

https://catalogue.data.gov.bc.ca/dataset/testing-1-6-5-release-dk