bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension
http://catalogue.data.gov.bc.ca
GNU Affero General Public License v3.0
24 stars 23 forks source link

Geographic draft records without resources should be viewable to branch editors. #323

Closed Mbrownshoes closed 7 years ago

Mbrownshoes commented 7 years ago

related to #315 Now that draft geographic records can be saved without resources, we would like these records to be indexed and viewable to branch editors - similar to other draft records. This will allow editors to find the draft records they have created and continue working on them. These records should appear here: screen shot 2017-04-26 at 9 26 18 am

jrods commented 7 years ago

@Mbrownshoes @gjlawran Is there any reason for datasets to have their state set to 'draft'? (not edc_state) If a dataset's state is 'active', then it can be indexed to be viewable on the branch organization view.

Continuing with #315 i can have those datasets that are saved to have an 'active' state when created.

Mbrownshoes commented 7 years ago

@jrods is the only time 'state' = 'draft' when a record doesn't have a resource? Seems that way as draft records with resources have states of active. If that is the case than yes, let's make the save active when you save it without a resource.

jrods commented 7 years ago

@Mbrownshoes yes that is the case, I can submit a PR to have resource-less datasets be set to active when saved

jrods commented 7 years ago

@Mbrownshoes I've tested in cad, the datasets are now active when saving a dataset without resources, but it doesn't show in the org branch list, how often does solr re-optimize?

@ll911

ll911 commented 7 years ago

It doesn’t get re-optimize in CAD. It’s on demand.

From: Jared Smith notifications@github.com Reply-To: bcgov/ckanext-bcgov reply@reply.github.com Date: Wednesday, May 17, 2017 at 11:52 AM To: bcgov/ckanext-bcgov ckanext-bcgov@noreply.github.com Cc: "Lou, Leo JTST:EX" Leo.Lou@gov.bc.ca, Mention mention@noreply.github.com Subject: Re: [bcgov/ckanext-bcgov] Geographic draft records without resources should be viewable to branch editors. (#323)

@Mbrownshoeshttps://github.com/mbrownshoes I've tested in cad, the datasets are now active when saving a dataset without resources, but it doesn't show in the org branch list, how often does solr re-optimize?

@ll911https://github.com/ll911

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/bcgov/ckanext-bcgov/issues/323#issuecomment-302194037, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALZU2aZPkjt2yB6wN6apbhwCaKQtvhhQks5r60HrgaJpZM4NJHD9.

Mbrownshoes commented 7 years ago

@jrods I indexed a record I just created without a resource and it is visible to branch editors

dkelsey commented 7 years ago

I created a Geographic Dataset without a resource https://cat.data.gov.bc.ca/dataset/testing-geographic-dataset-with-no-resource-dk Mat created one in the demo: https://cat.data.gov.bc.ca/dataset/show-and-tell

Both are visible to members of the organization, though both have no resources.

dkelsey commented 7 years ago

I created a dataset without a resource:

https://catalogue.data.gov.bc.ca/dataset/testing-1-6-5-release-dk

after 10 mins it was indexed and visible when logged in as another member of JTST. (dbcuser2)