Editors should not be able to hide all contact on published metadata records.

bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension

http://catalogue.data.gov.bc.ca

GNU Affero General Public License v3.0

24 stars 23 forks source link

Editors should not be able to hide all contact on published metadata records. #368

Open dkelsey opened 6 years ago

dkelsey commented 6 years ago

As and editor, when editing an already published metadata record that has a single point of contact, I should not be able to hide all contacts and update the record.

STEPS

Edit an already published record that has at least one point of contact.
hide all contacts.
press Update Records

EXPECTED

I should not be allowed to Update the Record. There should be a notice that at least one point of contact is required. ACTUAL
I can Update the record effectively hiding all points of contact.

mdunhamwilkie commented 5 years ago

Note: there are currently 38 such datasets. - querying from the exported version in WHSE_CORP:

SELECT * 
  FROM bcdc_datasets d 
 WHERE NOT exists (SELECT 1 
                    FROM bcdc_dataset_contacts c 
                   WHERE c.dataset_id = d.dataset_id 
                     AND c.contact_private = 'Display');

dkelsey commented 5 years ago

I had a look and these. The majority (30) come from a single organization. There are a number which are dataset created through the API which contain incomplete schema.

I'll follow up with these. When (if) this is resolved, it will put the organization that has the majority of records in this list in a difficult position.