bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension
http://catalogue.data.gov.bc.ca
GNU Affero General Public License v3.0
24 stars 23 forks source link

Set first option in select dropdown for Resource Storage Location to 'Catalogue Data Store' #546

Open dkelsey opened 6 years ago

dkelsey commented 6 years ago

ENV

PROD, CAT, CAD

TESTCASE

ACTUAL

This value will never be selected by an editor. Resources in the BC Geographic Warehouse are configured using a modal pop-up which fills in the required fields automatically.

dkelsey commented 6 years ago

This relates to #484

jachurchill commented 5 years ago

There isn't any options within the app to do this sorting, there was a similar issue for projection that was dealt with in a hack-y way. Issue: #375 There is some explanation in the pull request https://github.com/bcgov/ckanext-bcgov/pull/466#issue-175116602 do we want to do something similar, leave as is or look into a much deeper change?

mdunhamwilkie commented 5 years ago

@jachurchill I think we want to do something similar to way projection was handled in https://github.com/bcgov/ckanext-bcgov/pull/466#issue-175116602 . @dkelsey do you concur?

dkelsey commented 5 years ago

We could do the "hack-y" way for now.
Another alternative: My understanding is that no editor will every set resource storage location to BC Geographic Warehouse remove it from the list.

The only time resource storage location should be BC Geographic Warehouse, is when an editor has clicked "Manage BCGW Resources"; and in that case the component that sets that value does it (in correctly).

We should discuss this to decide on what action to take.

mdunhamwilkie commented 5 years ago

Let's do "Hack-y" for now. Dave is correct. datasets of the "dataset" type are never in the BCGW. datasets of the "Geographic Datasets" type are often in the BCGW, but not always. But I'd rather not remove the choice yet. We're considering merging the different classes of datasets into a single one - let's revisit this discussion then.

dkelsey commented 5 years ago

Ok I'd suggest we leave it as-is for now and not introduce more "hack-y-ness"