bcgov / ckanext-bcgov

BC Data Catalogue source code, main ckan extension
http://catalogue.data.gov.bc.ca
GNU Affero General Public License v3.0
24 stars 23 forks source link

Determine viability of replacing datapusher with xloader #696

Open hleckenb opened 5 years ago

hleckenb commented 5 years ago

User Story

As a BC Data Catalogue Administrator,
I want to ensure that data pushes to the Datastore succeed
**so that data loads can be trusted and not end up with partial/half loaded data or requiring manual or further administrative tasks to successfully push data to the Datastore.


Test Case

ENV

PROD, CAT, CAD **please verify environment

TESTCASE

*

EXPECTED

*

ACTUAL

*Datapusher creates 502 error As Dave describes below, when you do an Update Dataset the update fires a trigger that

From the logs it appears that it is this trigger that is running into problems. Specifically the trigger thinks that a resource is in the datastore, it tries to delete it and doesn’t handle the fact that it doesn’t exist very well. Why doesn’t it exist? In my testing I made sure that all the resources were in the datastore (by previewing them) before I did the Update Dataset. SO what happened to the resources that can be found? Could there be a competing process that has deleted them before the trigger tries to delete them? (i.e., a “race condition”). We also know that turning off the data pusher avoids the problem. Turning off the data pusher means that the trigger won’t be able to do anything and hence won’t get into trouble.

“Guessed” data type turning out to be wrong halfway through the file. There might be an issue with multiple heading lines. To fix the record that came up yesterday (with its 20 or so resources) will take the better part of a day, and Leo’s involvement, and the involvement of the data provider.

hleckenb commented 5 years ago

Investigate - Implemented xloader may remove/reduce error return. https://github.com/ckan/ckan/issues/4415

hleckenb commented 5 years ago

@dkelsey please complete the test case for this.

dkelsey commented 5 years ago

I have more to say but i'll stop there.