bcgov / climr

An R package for downscaling monthly climate data for North America
https://bcgov.github.io/climr/
16 stars 5 forks source link

Refer to columns by name, not index + using `data.table` #183

Closed CeresBarros closed 9 months ago

CeresBarros commented 10 months ago

Several functions involved in downscaling were referring to columns using indices, instead of names. This is no robust to changes in column order. As part of the changes to use column names throughout I have:

This PR also addresses

178

133

159

CeresBarros commented 9 months ago

test failures are due to server issues and arbitrarily pass in ubuntu and win (release versions). MacOS keeps hitting server errors.

These failures are not related to pkg code (as far as I and @kdaust can tell). Merging PR as it brings important changes to continue development