search

bcgov / climr

An R package for downscaling monthly climate data for North America
https://bcgov.github.io/climr/
16 stars 5 forks source link

Miscellaneous edits to documentation and vignettes #212

Closed cmahony closed 8 months ago

cmahony commented 9 months ago

@CeresBarros I may make further commits to this PR. check with me prior to merging.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (25c39e7) 78.07% compared to head (285e0b6) 78.07%.

:exclamation: Current head 285e0b6 differs from pull request most recent head 2b12c74. Consider uploading reports for the commit 2b12c74 to get more accurate results

Files Patch % Lines
R/plot_bivariate.R 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devl #212 +/- ## ======================================= Coverage 78.07% 78.07% ======================================= Files 23 23 Lines 1861 1861 ======================================= Hits 1453 1453 Misses 408 408 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CeresBarros commented 9 months ago

@cmahony please note that devl has suffered changes so you'll need to re-merge devl into colin_edits

cmahony commented 9 months ago

@CeresBarros i've resolved all of the change requests.

CeresBarros commented 8 months ago

I'll re-run the pkg checks. they seem to have failed to due to server issues.

cmahony commented 8 months ago

climr server may be down due to kiri's database updates. no hurry on this as we won't release until the gcm data is complete.

CeresBarros commented 8 months ago

merging to allow continued development, despite test fails (these are related to incomplete server data). Future PR's to development should make sure tests pass.