search

bcgov / climr

An R package for downscaling monthly climate data for North America
https://bcgov.github.io/climr/
16 stars 5 forks source link

Bug fix in plot_bivariate #219

Closed cmahony closed 7 months ago

cmahony commented 8 months ago

one-line bug fix, with bump and NEWS and redoc.

CeresBarros commented 8 months ago

All vignette builds are now failing with some sort of data.frame algebra error. This should be investigated before merging, even if not related to your bugfix.

@kdaust Have you seen this during your own checks?

cmahony commented 8 months ago

I'm getting these fails as well in my own runs on devl.

kdaust commented 8 months ago

Sorry this is all my fault. I'll try and fix tonight

cmahony commented 8 months ago

Sorry this is all my fault. I'll try and fix tonight

@kdaust no problems! it can wait until later this week if you have other things on the go.

kdaust commented 8 months ago

I think it's fixed. Tests are running now

CeresBarros commented 8 months ago

I merged @kdaust 's fixes and relaunched tests

kdaust commented 8 months ago

I think the tests will still fail due to the out$GCM error. It's also failing locally, but I haven't been able to pinpoint the bug yet

kdaust commented 7 months ago

All tests passing except for the one due to incorrect comparison data. Merged

CeresBarros commented 7 months ago

Reminder: please rebuild the testing datasets on the new main branch version, push and re run tests (maybe locally?) to make sure all is passing On 10 Apr 2024, at 17:36, Kiri Daust @.**@.>> wrote:

All tests passing except for the one due to incorrect comparison data. Merged

— Reply to this email directly, view it on GitHubhttps://github.com/bcgov/climr/pull/219#issuecomment-2048649680, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJPMUAZC6BNNCZRLIP44STY4XLHLAVCNFSM6AAAAABEQTNCP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGY2DSNRYGA. You are receiving this because your review was requested.Message ID: @.***>