search

bcgov / climr

An R package for downscaling monthly climate data for North America
https://bcgov.github.io/climr/
16 stars 5 forks source link

plot_timeSeries functions #244

Closed cmahony closed 6 months ago

cmahony commented 6 months ago

two new functions for time series plotting. note that i made changes to the Variables_ClimateBC.csv table; something to check there aren't any downstream implcations. Also need help with my @importFrom documentation.

cmahony commented 6 months ago

@CeresBarros last question is around how i treated the requirement for packages 'scales' and 'stinepack' (line 111). can you check that i got this right?

cmahony commented 6 months ago

@CeresBarros also... thanks so much for the review!!

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 70.97%. Comparing base (254dcf7) to head (efdb2e8). Report is 98 commits behind head on devl.

:exclamation: Current head efdb2e8 differs from pull request most recent head 9ca1cf4. Consider uploading reports for the commit 9ca1cf4 to get more accurate results

Files Patch % Lines
R/plot_timeSeries.R 0.00% 176 Missing :warning:
R/plot_timeSeries_input.R 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devl #244 +/- ## ========================================== - Coverage 78.07% 70.97% -7.11% ========================================== Files 23 25 +2 Lines 1861 2122 +261 ========================================== + Hits 1453 1506 +53 - Misses 408 616 +208 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.