bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Helm Chart cannot use a database if patroni.enabled=false #131

Closed pbolduc closed 1 year ago

pbolduc commented 1 year ago

Describe the bug

When using the Helm chart, if I set patroni.enabled=false, the chart cannot be deployed due to an error. I want to use a different HA database deployed separately from the COMS helm chart. We have a number of databases in our system, I do not want duplicate Patroni clusters which requires more resources and monitoring.

To Reproduce

Steps to reproduce the behavior:

  1. Run

helm upgrade coms ./common-object-management-service-0.0.8.tgz --install --values coms-values.yaml --set patroni.enabled=false

  1. See error,

Error: template: common-object-management-service/templates/deploymentconfig.yaml:43:27: executing "common-object-management-service/templates/deploymentconfig.yaml" at <include "patroni.fullname" .Subcharts.patroni>: error calling include: template: no template "patroni.fullname" associated with template "gotpl"

Expected behavior

I would be expected if not enabling patroni in the chart, I can reference an existing postgres database with appropriate credentials.

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

jujaga commented 1 year ago

Thanks for this report. We have plans to support non-Patroni dependency managed databases via the dbSecretOverride value in values.yaml and have added it into our backlog.

jujaga commented 1 year ago

Addressed in #158