bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Validate default bucket configuration on startup #208

Closed TimCsaky closed 1 year ago

TimCsaky commented 1 year ago

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3337 .. and some other changes required to make the default bucket feature optional.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Further comments

github-actions[bot] commented 1 year ago

Coverage Report

Totals Coverage
Statements: 52.45% ( 2466 / 4702 )
Methods: 42.54% ( 268 / 630 )
Lines: 58.67% ( 1496 / 2550 )
Branches: 46.12% ( 702 / 1522 )
codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit d5941aee and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 81.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.6% (0.1% change).

View more on Code Climate.