bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Attribute Sync to system user #211

Closed TimCsaky closed 1 year ago

TimCsaky commented 1 year ago

Description

previously, we were marking new records with a createdBy of user that requested the sync. So for example, in bcbox, a synced object is showing as createdBy the user that clicked sync. We feel its more accurate, and in keeping with the existing pattern to show it as createdBy 'system user' (nil uuid) in the database.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

Further comments

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit c6ca130c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.7% (0.0% change).

View more on Code Climate.

github-actions[bot] commented 1 year ago

Coverage Report

Totals Coverage
Statements: 52.49% ( 2468 / 4702 )
Methods: 42.54% ( 268 / 630 )
Lines: 58.75% ( 1498 / 2550 )
Branches: 46.12% ( 702 / 1522 )