bcgov / common-object-management-service

A microservice for managing access control to S3 Objects

https://bcgov.github.io/common-object-management-service/

Apache License 2.0

6 stars 9 forks source link

remove default S3 upload queuesize override #213

Closed TimCsaky closed 1 year ago

TimCsaky commented 1 year ago

Description

remove default S3 upload queue size override queue size represents a limit to how many parts can be processed in parallel. increasing to 4 may prevent memory spikes in memory usage of COMS as the file 'backs up' in a memory buffer.

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit a19b0923 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2
Duplication	6

The test coverage on the diff in this pull request is 7.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 63.5% (-0.9% change).

View more on Code Climate.

github-actions[bot] commented 1 year ago

Coverage Report

Totals
Statements:	57.05% ( 2619 / 4591 )
Methods:	47.01% ( 291 / 619 )
Lines:	63.57% ( 1574 / 2476 )
Branches:	50.4% ( 754 / 1496 )