bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

RFC 7807 Compliance #217

Closed jujaga closed 1 year ago

jujaga commented 1 year ago

Description

This PR standardizes how we emit errors to be RFC 7807 compliant, implements a thin validation middleware, standardizes problem handling, and various other minor fixes.

Types of changes

Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Documentation (non-breaking change with enhancements to documentation) Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Further comments

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 6329d2ff and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 6

The test coverage on the diff in this pull request is 84.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 64.7% (0.2% change).

View more on Code Climate.

github-actions[bot] commented 1 year ago

Coverage Report

Totals Coverage
Statements: 58% ( 2645 / 4560 )
Methods: 47.98% ( 297 / 619 )
Lines: 64.71% ( 1590 / 2457 )
Branches: 51.08% ( 758 / 1484 )