bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Add ability to set database connection string #221

Closed pbolduc closed 3 months ago

pbolduc commented 1 year ago

Description

Adds the ability to use an optional onnectionString property. This would allow customizing any of the connecting string properties without having to configure each property individually.

Fixes #220

Types of changes

Checklist

Further comments

pbolduc commented 1 year ago

I understand your team is currently in the process of a major 0.7 release. I would appreciate once the dust settles, if you could discuss and review this PR. I understand there may not be an appetite for exposing the connection string as a configuration variable directly.

pbolduc commented 1 year ago

For reference, I believe the Postgres client uses node-postgres which in turn uses pg-connection-string for parsing connection strings. The pg-connection-string package provides docs on the options for this field.

TimCsaky commented 3 months ago

Closing this because it's been a few months. We have captured this task in our backlog as a feature we may want to implement at a later date.