bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Use isLatest db value in object search query #222

Closed TimCsaky closed 1 year ago

TimCsaky commented 1 year ago

We need to update our search objects query to take advantage of the isLatest boolean we added to the db schema (previously we used createdAt date desc to work out latest).

This change fixes a bug where soft deleted files are showing up in bcbox.

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

Further comments

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 862f0975 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 64.7% (0.0% change).

View more on Code Climate.

github-actions[bot] commented 1 year ago

Coverage Report

Totals Coverage
Statements: 58.04% ( 2649 / 4564 )
Methods: 47.98% ( 297 / 619 )
Lines: 64.74% ( 1592 / 2459 )
Branches: 51.14% ( 760 / 1486 )