bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Change SyncTags to only backfill coms-id tag for latest version #224

Closed TimCsaky closed 1 year ago

TimCsaky commented 1 year ago

writing coms-id to tag to all versions in S3 alters Last Modified date for objects in Dell ECS, so we avoid soing this during a sync.

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3387

during sync of objects in Dell S3, the SyncTags() sub-routine adds coms-id tag which in turn was altering Last Modified property of all S3 versions. This is an unwanted side-affect that may confuse file owners looking at dates. (see JIRA ticket for logs) Solution is to only add coms-id tag to latest version which does not alter Last Modified for any version.

Types of changes

Checklist

Further comments

github-actions[bot] commented 1 year ago

Coverage Report

Totals Coverage
Statements: 58.07% ( 2651 / 4565 )
Methods: 47.98% ( 297 / 619 )
Lines: 64.74% ( 1592 / 2459 )
Branches: 51.24% ( 762 / 1487 )
codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit a3d90f44 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 64.7% (0.0% change).

View more on Code Climate.